rm weights.load() #306
Merged
rm weights.load() #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 94.53% 94.50% -0.03%
==========================================
Files 23 23
Lines 2542 2566 +24
==========================================
+ Hits 2403 2425 +22
- Misses 139 141 +2
Continue to review full report at Codecov.
|
added 2 commits
May 6, 2021 08:04
|
Apologies @raybellwaves I didn't get to this today, but I should be able to take a look this weekend |
|
If ok. I'm going to merge. Minor refactor PR. and taking a look at some of the failures in #307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #265
This may have been needed at one point but the tests pass without it and it may free up #221